Claude review: Introduce Xe Uncorrectable Error Handling

[Claude Code Review Bot <claude-review@example.com>]

Patch Review

Marked "DO NOT REVIEW. COMPILATION ONLY" — this is a dependency from a separate series. I'll note issues that affect the later patches in this series.

**Critical: Uninitialized variable in `handle_page_offline()`**

```c
static int handle_page_offline(struct xe_device *xe, u64 page_address, bool send_offline_cmd)
{
	enum xe_ras_page_action action;
	int ret;
	...
	/*
	 * TODO: Call function to handle address fault
	 * ret = xe_ttm_vram_handle_addr_fault(xe, page_address);
	 */
	...
	switch (ret) {
```

`ret` is declared but never assigned — the only assignment (`xe_ttm_vram_handle_addr_fault`) is commented out as a TODO. The `switch (ret)` uses an uninitialized value, which is undefined behavior. This will produce compiler warnings and unpredictable runtime behavior. If this function is truly a placeholder, it should either: (a) hardcode `ret = 0`, or (b) not be included until the dependency is ready.

**Duplicate `#define XE_SYSCTRL_FLOOD`**

The patch renames `XE_SYSCTRL_EVENT_FLOOD` to `XE_SYSCTRL_FLOOD` in `xe_sysctrl_event_types.h`:
```c
-#define XE_SYSCTRL_EVENT_FLOOD			16
+#define XE_SYSCTRL_FLOOD			16
```

And also adds it to `xe_sysctrl_mailbox_types.h`:
```c
+#define XE_SYSCTRL_FLOOD			16
```

This creates a duplicate definition of the same macro in two different headers. It should be defined in only one place — likely `xe_sysctrl_mailbox_types.h` since both the event and RAS code share it, and `xe_sysctrl_event_types.h` should just include that header or the define should be in a common location.

**`xe_pci_error_slot_reset` calls probe/remove directly**

```c
xe_device_clear_in_reset(xe);
pdev->driver->remove(pdev);
devres_release_group(&pdev->dev, xe->devres_group_id);

if (pdev->driver->probe(pdev, ent))
	return PCI_ERS_RESULT_DISCONNECT;
```

Calling `pdev->driver->remove()` and `pdev->driver->probe()` directly from a PCI error handler is unusual and fragile. After `remove()`, the `xe` pointer used to access `xe->devres_group_id` is stale (though the order here accesses it before freeing). This pattern deserves careful scrutiny in the parent series review.

**`xe_pci_error_handling` bypasses wedge API**

```c
static void xe_pci_error_handling(struct pci_dev *pdev)
{
	...
	atomic_set(&xe->wedged.flag, 1);
```

The wedge flag is set directly via `atomic_set` rather than through `xe_device_declare_wedged()`. The resume path similarly clears it with `atomic_set(&xe->wedged.flag, 0)`. This bypasses the normal wedge uevent notification and any future invariants the wedge API might enforce. While this may be intentional (the comment says "don't send the event yet"), it creates a maintenance risk.

---

---
Generated by Claude Code Patch Reviewer