public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/xe: Handle PUNIT errors by requesting cold-reset recovery
Date: Sat, 16 May 2026 13:17:49 +1000	[thread overview]
Message-ID: <review-patch4-20260512132614.1793083-11-mallesh.koujalagi@intel.com> (raw)
In-Reply-To: <20260512132614.1793083-11-mallesh.koujalagi@intel.com>

Patch Review

This is the core functional patch and is quite small.

```c
+static void punit_error_handler(struct xe_device *xe)
+{
+	xe_device_set_wedged_method(xe, DRM_WEDGE_RECOVERY_COLD_RESET);
+	xe_device_declare_wedged(xe);
+}
```

Clean and correct — sets the recovery method, then declares the device wedged, which triggers the uevent to userspace.

The call site change is also correct:
```c
-			/* TODO: Add PUNIT error handling */
+			punit_error_handler(xe);
 			return XE_RAS_RECOVERY_ACTION_DISCONNECT;
```

The function is properly `static` (as requested in v4 review feedback) and the `xe_` prefix is removed (v5 feedback). 

**Note:** `xe_assert.h` and `xe_device_types.h` are added as includes but neither appears to be directly needed by the code added in this patch. The `xe_assert.h` include is unused. `xe_device_types.h` would already be pulled in transitively through `xe_device.h`. These may be leftover from a previous version.

```c
+#include "xe_assert.h"
+#include "xe_device_types.h"
```

---

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-05-16  3:17 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-12 13:26 [PATCH v5 0/5] Introduce cold reset recovery method Mallesh Koujalagi
2026-05-12 13:26 ` [PATCH v5 1/5] Introduce Xe Uncorrectable Error Handling Mallesh Koujalagi
2026-05-16  3:17   ` Claude review: " Claude Code Review Bot
2026-05-12 13:26 ` [PATCH v5 2/5] drm: Add DRM_WEDGE_RECOVERY_COLD_RESET recovery method Mallesh Koujalagi
2026-05-14  7:59   ` Raag Jadav
2026-05-14  9:12   ` Tauro, Riana
2026-05-16  3:17   ` Claude review: " Claude Code Review Bot
2026-05-12 13:26 ` [PATCH v5 3/5] drm/doc: Document " Mallesh Koujalagi
2026-05-14  8:50   ` Raag Jadav
2026-05-16  3:17   ` Claude review: " Claude Code Review Bot
2026-05-12 13:26 ` [PATCH v5 4/5] drm/xe: Handle PUNIT errors by requesting cold-reset recovery Mallesh Koujalagi
2026-05-14  8:13   ` Raag Jadav
2026-05-16  3:17   ` Claude Code Review Bot [this message]
2026-05-12 13:26 ` [PATCH v5 5/5] drm/xe: Suppress Surprise Link Down on non-hotplug device Mallesh Koujalagi
2026-05-14  8:35   ` Raag Jadav
2026-05-14  9:36   ` Tauro, Riana
2026-05-16  3:17   ` Claude review: " Claude Code Review Bot
2026-05-16  3:17 ` Claude review: Introduce cold reset recovery method Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-04-06 14:23 [PATCH v3 0/4] " Mallesh Koujalagi
2026-04-06 14:23 ` [PATCH v3 4/4] drm/xe: Handle PUNIT errors by requesting cold-reset recovery Mallesh Koujalagi
2026-04-12  4:32   ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch4-20260512132614.1793083-11-mallesh.koujalagi@intel.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox