public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/doc: Document DRM_WEDGE_RECOVERY_COLD_RESET recovery method
Date: Mon, 25 May 2026 21:57:09 +1000	[thread overview]
Message-ID: <review-patch3-20260520113351.171119-10-mallesh.koujalagi@intel.com> (raw)
In-Reply-To: <20260520113351.171119-10-mallesh.koujalagi@intel.com>

Patch Review

Good documentation. The example script is practical and the v6 improvement (looking up the slot via `DEVPATH/slot` symlink instead of scanning all slots) is a real improvement.

Minor nits:

- The script variables (`$DEVICE`, `$DEVPATH`) are unquoted in most uses. PCI paths don't contain spaces so this is fine in practice, but the leading `readlink -f /sys/$1/device` on line 1 should be `readlink -f "/sys/$1/device"` for robustness.

- The `||` fallback in the script is slightly confusing:
```
DEVPATH=$(readlink -f /sys/$1/device 2>/dev/null || readlink -f /sys/$1)
```
If the first `readlink` fails (not a card subdirectory), it falls back to `readlink -f /sys/$1`. This seems intentional but isn't documented.

These are minor — the doc serves its purpose well.

---

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-05-25 11:57 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-20 11:33 [PATCH v6 0/5] Introduce cold reset recovery method Mallesh Koujalagi
2026-05-20 11:33 ` [PATCH v6 1/5] Introduce Xe Uncorrectable Error Handling Mallesh Koujalagi
2026-05-25 11:57   ` Claude review: " Claude Code Review Bot
2026-05-20 11:33 ` [PATCH v6 2/5] drm: Add DRM_WEDGE_RECOVERY_COLD_RESET recovery method Mallesh Koujalagi
2026-05-25 11:57   ` Claude review: " Claude Code Review Bot
2026-05-20 11:33 ` [PATCH v6 3/5] drm/doc: Document " Mallesh Koujalagi
2026-05-25 11:57   ` Claude Code Review Bot [this message]
2026-05-20 11:33 ` [PATCH v6 4/5] drm/xe: Handle PUNIT errors by requesting cold-reset recovery Mallesh Koujalagi
2026-05-25 11:57   ` Claude review: " Claude Code Review Bot
2026-05-20 11:33 ` [PATCH v6 5/5] drm/xe: Suppress Surprise Link Down on non-hotplug device Mallesh Koujalagi
2026-05-25 11:57   ` Claude review: " Claude Code Review Bot
2026-05-25 11:57 ` Claude review: Introduce cold reset recovery method Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-05-12 13:26 [PATCH v5 0/5] " Mallesh Koujalagi
2026-05-12 13:26 ` [PATCH v5 3/5] drm/doc: Document DRM_WEDGE_RECOVERY_COLD_RESET " Mallesh Koujalagi
2026-05-16  3:17   ` Claude review: " Claude Code Review Bot
2026-04-06 14:23 [PATCH v3 0/4] Introduce cold reset " Mallesh Koujalagi
2026-04-06 14:23 ` [PATCH v3 3/4] drm/doc: Document DRM_WEDGE_RECOVERY_COLD_RESET " Mallesh Koujalagi
2026-04-12  4:32   ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch3-20260520113351.171119-10-mallesh.koujalagi@intel.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox