Claude review: gpu: nova-core: run unload sequence upon unbinding

[Claude Code Review Bot <claude-review@example.com>]

Overall Series Review

Subject: gpu: nova-core: run unload sequence upon unbinding
Author: Alexandre Courbot <acourbot@nvidia.com>
Patches: 9
Reviewed: 2026-06-04T16:57:32.956770

---

This is a well-structured 4-patch series by Alexandre Courbot (NVIDIA) that adds proper GPU unload/teardown for the nova-core driver. Currently, when the driver unbinds, the GSP firmware is left running and the WPR2 memory region is not cleaned up, which means a GPU reset is required before the driver can probe again. This is particularly problematic on Blackwell where PCI reset can corrupt the GPU.

The series is logically decomposed:
1. Extract chipset-specific boot code into a HAL pattern
2. Send the `UNLOADING_GUEST_DRIVER` command to stop the GSP
3. Run Booter Unloader and FWSEC-SB to reset WPR2 region
4. Add a drop guard to run the unload bundle on boot failure

The code quality is high — good error handling, proper use of Rust's type system to enforce lifecycle constraints (one-shot unload bundle, drop guards), and the HAL abstraction prepares cleanly for Hopper/Blackwell FSP boot paths. The v7 changelog shows this series has received thorough review iterations.

**Verdict**: Looks good overall. A few observations below, mostly minor.

---

---
Generated by Claude Code Patch Reviewer