Claude review: media: meson: Fix memory leak in error path in vdec

[Claude Code Review Bot <claude-review@example.com>]

Overall Series Review

Subject: media: meson: Fix memory leak in error path in vdec
Author: Anand Moon <linux.amoon@gmail.com>
Patches: 9
Reviewed: 2026-06-04T15:48:45.580056

---

This is a v6 series of 8 patches fixing various bugs in the Amlogic Meson VDEC staging driver, primarily addressing memory leaks, race conditions, and NULL pointer dereferences reported by the Sashiko bot. The series touches real bugs — the original code has genuine lifetime, synchronization, and error-handling issues. However, several patches have correctness problems that introduce new bugs or are questionable in their approach.

**Key concerns:**
1. **Patch 3** double-frees `sess->priv` — `codec_ops->stop()` already frees it, then the error path does `kfree(sess->priv)` again.
2. **Patch 5** moves `codec_ops->drain()` before hardware teardown, which changes behavior in a potentially unsafe way — drain runs while hardware is still active but status is already set to `STATUS_STOPPED`.
3. **Patch 7** uses `READ_ONCE()` on `core->cur_sess` but the matching writes in patches 2/5 don't use `WRITE_ONCE()`, and the fix is insufficient for the claimed race — an IRQF_ONESHOT handler still accesses session fields after the pointer check.
4. **Patch 1** has an error-path ordering issue — `v4l2_fh_del()` is never called in the error unwind for `vdec_open()`.

The series seems largely AI-generated (Sashiko bot reports, cover letter tone), and while the problems identified are real, the fixes need more careful thought about ordering, locking, and double-free hazards.

---

---
Generated by Claude Code Patch Reviewer