public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: media: meson: vdec: Cancel esparser work during teardown
Date: Thu, 04 Jun 2026 15:48:46 +1000	[thread overview]
Message-ID: <review-patch5-20260530094326.11892-6-linux.amoon@gmail.com> (raw)
In-Reply-To: <20260530094326.11892-6-linux.amoon@gmail.com>

Patch Review

**Good:** Adding `cancel_work_sync()` in teardown paths is the right approach.

**Issue — drain moved before hardware teardown:**
```c
cancel_work_sync(&sess->esparser_queue_work);

mutex_lock(&core->lock);
...
sess->status = STATUS_STOPPED;
mutex_unlock(&core->lock);

if (q->type != V4L2_BUF_TYPE_VIDEO_OUTPUT_MPLANE) {
    if (old_status >= STATUS_RUNNING && codec_ops->drain)
        codec_ops->drain(sess);
}

if (old_status == STATUS_RUNNING || ...)
    ...
    vdec_poweroff(sess);  /* also calls drain() internally! */
```

There are two problems here:
1. `codec_ops->drain()` is now called **before** `vdec_poweroff()`, but `vdec_poweroff()` also calls `codec_ops->drain()` internally (line 122-123 of the original). So drain is called **twice** — once explicitly here, and once inside `vdec_poweroff()`.
2. The commit message says "Move codec_ops->drain() evaluation earlier in stop_streaming() using the status snapshot, so draining occurs before buffer cleanup." But the original code already drained before buffer cleanup (drain was in the `else` branch before `v4l2_m2m_dst_buf_remove()`). The move creates the double-drain issue.

**Issue — `cancel_work_sync` in `vdec_close`:** This is fine as defense-in-depth, since `v4l2_m2m_ctx_release()` should trigger `stop_streaming` which already cancels it (after this patch).

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-06-04  5:48 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-30  9:42 [PATCH v6 0/8] media: meson: Fix memory leak in error path in vdec Anand Moon
2026-05-30  9:42 ` [PATCH v6 1/8] media: meson: vdec: Fix memory leaks and lifetime of m2m device Anand Moon
2026-06-04  5:48   ` Claude review: " Claude Code Review Bot
2026-05-30  9:42 ` [PATCH v6 2/8] media: meson: vdec: Fix concurrent STREAMON / STREAMOFF race conditions Anand Moon
2026-06-04  5:48   ` Claude review: " Claude Code Review Bot
2026-05-30  9:42 ` [PATCH v6 3/8] media: meson: vdec: Handle kthread failure and free codec state Anand Moon
2026-06-04  5:48   ` Claude review: " Claude Code Review Bot
2026-05-30  9:42 ` [PATCH v6 4/8] media: meson: vdec: Condition buffer flushing on queue type in start_streaming Anand Moon
2026-06-04  5:48   ` Claude review: " Claude Code Review Bot
2026-05-30  9:42 ` [PATCH v6 5/8] media: meson: vdec: Cancel esparser work during teardown Anand Moon
2026-06-04  5:48   ` Claude Code Review Bot [this message]
2026-05-30  9:42 ` [PATCH v6 6/8] media: meson: vdec: Configure DMA mask and segment size in probe Anand Moon
2026-06-04  5:48   ` Claude review: " Claude Code Review Bot
2026-05-30  9:42 ` [PATCH v6 7/8] media: meson: vdec: Fix NULL pointer dereference in ISR handlers Anand Moon
2026-06-04  5:48   ` Claude review: " Claude Code Review Bot
2026-05-30  9:42 ` [PATCH v6 8/8] gpu: drm: meson: Fix DMA max segment size for DMABUF imports Anand Moon
2026-06-04  5:48   ` Claude review: " Claude Code Review Bot
2026-06-04  5:48 ` Claude review: media: meson: Fix memory leak in error path in vdec Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch5-20260530094326.11892-6-linux.amoon@gmail.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox