From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: media: meson: vdec: Fix NULL pointer dereference in ISR handlers
Date: Thu, 04 Jun 2026 15:48:47 +1000 [thread overview]
Message-ID: <review-patch7-20260530094326.11892-8-linux.amoon@gmail.com> (raw)
In-Reply-To: <20260530094326.11892-8-linux.amoon@gmail.com>
Patch Review
**Incomplete fix — READ_ONCE without WRITE_ONCE:** The patch uses `READ_ONCE()` on the read side:
```c
sess = READ_ONCE(core->cur_sess);
```
But the writes to `core->cur_sess` in patches 2 and 5 are plain stores protected by a mutex:
```c
core->cur_sess = sess; /* in start_streaming */
core->cur_sess = NULL; /* in stop_streaming */
```
For `READ_ONCE()` to be meaningful, the matching writes should use `WRITE_ONCE()`. Without it, the compiler could still tear the write, though in practice pointer writes on ARM64 are atomic. Still, for correctness, `WRITE_ONCE()` should be added to the write side.
**Insufficient fix — TOCTOU on session fields:** Even with the NULL check, there's a race:
```c
sess = READ_ONCE(core->cur_sess);
if (!sess)
return IRQ_NONE;
/* sess could be freed right here by stop_streaming */
sess->last_irq_jiffies = get_jiffies_64();
```
After the NULL check, `stop_streaming` can still run, clear `cur_sess`, and proceed to free session resources. The session pointer obtained by READ_ONCE is not pinned. This requires either:
- Disabling interrupts during teardown (`disable_irq()` before clearing `cur_sess`), or
- Using RCU to protect the session pointer, or
- Some other synchronization.
The IRQ is registered with `IRQF_ONESHOT` and uses a threaded handler, so `disable_irq_nosync()` / `synchronize_irq()` before clearing `cur_sess` would be the typical kernel pattern.
**Unnecessary variable:** The `ret` variable in `vdec_isr`:
```c
irqreturn_t ret = IRQ_HANDLED;
...
ret = sess->fmt_out->codec_ops->isr(sess);
return ret;
```
The initial assignment `ret = IRQ_HANDLED` is dead code since `ret` is unconditionally overwritten. Just return the call result directly.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-06-04 5:48 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-30 9:42 [PATCH v6 0/8] media: meson: Fix memory leak in error path in vdec Anand Moon
2026-05-30 9:42 ` [PATCH v6 1/8] media: meson: vdec: Fix memory leaks and lifetime of m2m device Anand Moon
2026-06-04 5:48 ` Claude review: " Claude Code Review Bot
2026-05-30 9:42 ` [PATCH v6 2/8] media: meson: vdec: Fix concurrent STREAMON / STREAMOFF race conditions Anand Moon
2026-06-04 5:48 ` Claude review: " Claude Code Review Bot
2026-05-30 9:42 ` [PATCH v6 3/8] media: meson: vdec: Handle kthread failure and free codec state Anand Moon
2026-06-04 5:48 ` Claude review: " Claude Code Review Bot
2026-05-30 9:42 ` [PATCH v6 4/8] media: meson: vdec: Condition buffer flushing on queue type in start_streaming Anand Moon
2026-06-04 5:48 ` Claude review: " Claude Code Review Bot
2026-05-30 9:42 ` [PATCH v6 5/8] media: meson: vdec: Cancel esparser work during teardown Anand Moon
2026-06-04 5:48 ` Claude review: " Claude Code Review Bot
2026-05-30 9:42 ` [PATCH v6 6/8] media: meson: vdec: Configure DMA mask and segment size in probe Anand Moon
2026-06-04 5:48 ` Claude review: " Claude Code Review Bot
2026-05-30 9:42 ` [PATCH v6 7/8] media: meson: vdec: Fix NULL pointer dereference in ISR handlers Anand Moon
2026-06-04 5:48 ` Claude Code Review Bot [this message]
2026-05-30 9:42 ` [PATCH v6 8/8] gpu: drm: meson: Fix DMA max segment size for DMABUF imports Anand Moon
2026-06-04 5:48 ` Claude review: " Claude Code Review Bot
2026-06-04 5:48 ` Claude review: media: meson: Fix memory leak in error path in vdec Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch7-20260530094326.11892-8-linux.amoon@gmail.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox