public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: media: meson: vdec: Fix memory leaks and lifetime of m2m device
Date: Thu, 04 Jun 2026 15:48:45 +1000	[thread overview]
Message-ID: <review-patch1-20260530094326.11892-2-linux.amoon@gmail.com> (raw)
In-Reply-To: <20260530094326.11892-2-linux.amoon@gmail.com>

Patch Review

**Good:** Moving `v4l2_m2m_init()`/`v4l2_m2m_release()` from per-session to per-device is the correct fix. The m2m device should be shared across sessions.

**Good:** Adding `v4l2_ctrl_handler_free()` in `vdec_close()` fixes a real leak shown in the kmemleak trace.

**Issue — error path in `vdec_open()` skips `v4l2_fh_del()`:**

The original `vdec_open()` calls `v4l2_fh_init()` and `v4l2_fh_add()` before returning success (lines 909-911 of the original). The new error path is:

```c
err_fh_del:
	v4l2_fh_exit(&sess->fh);
err_free_sess:
	kfree(sess);
```

The label says `err_fh_del` but only calls `v4l2_fh_exit()` — it never calls `v4l2_fh_del()`. Looking at the original code, `v4l2_fh_add()` is called **after** the point where `err_fh_del` would be jumped to (when `v4l2_m2m_ctx_init` fails), so `v4l2_fh_del()` may not be needed there. But the label name is misleading. However, if `vdec_init_ctrls()` fails, the code jumps to `err_free_sess` which skips the `v4l2_fh_exit()` entirely, and also leaks `sess->m2m_ctx` since `v4l2_m2m_ctx_release()` is never called. The error label when `vdec_init_ctrls()` fails should be `err_fh_del` (or a new label that releases the m2m ctx), not `err_free_sess`.

**Issue — `vdec_remove` ordering:** The `v4l2_m2m_release()` is called in `vdec_remove()` after `v4l2_device_unregister()`, which is correct, but `video_unregister_device()` should block until all open sessions are closed, so there shouldn't be an issue.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-06-04  5:48 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-30  9:42 [PATCH v6 0/8] media: meson: Fix memory leak in error path in vdec Anand Moon
2026-05-30  9:42 ` [PATCH v6 1/8] media: meson: vdec: Fix memory leaks and lifetime of m2m device Anand Moon
2026-06-04  5:48   ` Claude Code Review Bot [this message]
2026-05-30  9:42 ` [PATCH v6 2/8] media: meson: vdec: Fix concurrent STREAMON / STREAMOFF race conditions Anand Moon
2026-06-04  5:48   ` Claude review: " Claude Code Review Bot
2026-05-30  9:42 ` [PATCH v6 3/8] media: meson: vdec: Handle kthread failure and free codec state Anand Moon
2026-06-04  5:48   ` Claude review: " Claude Code Review Bot
2026-05-30  9:42 ` [PATCH v6 4/8] media: meson: vdec: Condition buffer flushing on queue type in start_streaming Anand Moon
2026-06-04  5:48   ` Claude review: " Claude Code Review Bot
2026-05-30  9:42 ` [PATCH v6 5/8] media: meson: vdec: Cancel esparser work during teardown Anand Moon
2026-06-04  5:48   ` Claude review: " Claude Code Review Bot
2026-05-30  9:42 ` [PATCH v6 6/8] media: meson: vdec: Configure DMA mask and segment size in probe Anand Moon
2026-06-04  5:48   ` Claude review: " Claude Code Review Bot
2026-05-30  9:42 ` [PATCH v6 7/8] media: meson: vdec: Fix NULL pointer dereference in ISR handlers Anand Moon
2026-06-04  5:48   ` Claude review: " Claude Code Review Bot
2026-05-30  9:42 ` [PATCH v6 8/8] gpu: drm: meson: Fix DMA max segment size for DMABUF imports Anand Moon
2026-06-04  5:48   ` Claude review: " Claude Code Review Bot
2026-06-04  5:48 ` Claude review: media: meson: Fix memory leak in error path in vdec Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260530094326.11892-2-linux.amoon@gmail.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox