From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: media: meson: vdec: Configure DMA mask and segment size in probe
Date: Thu, 04 Jun 2026 15:48:47 +1000 [thread overview]
Message-ID: <review-patch6-20260530094326.11892-7-linux.amoon@gmail.com> (raw)
In-Reply-To: <20260530094326.11892-7-linux.amoon@gmail.com>
Patch Review
**Questionable — 64-bit DMA mask for Amlogic SoCs:** Setting `DMA_BIT_MASK(64)` is unusual for these SoCs. Amlogic Meson GX/G12A SoCs typically have 32-bit address spaces for their peripherals. A 64-bit DMA mask might silently work if the IOMMU or swiotlb handles it, but it's misleading. The correct mask depends on the actual hardware capability. Most Amlogic drivers use 32-bit masks or rely on the default. Consider using `DMA_BIT_MASK(32)`.
**Minor:** `vb2_dma_contig_set_max_seg_size()` is fine, this is common practice for V4L2 drivers.
**Missing cleanup:** `vb2_dma_contig_set_max_seg_size()` allocates `dev->dma_parms` via `kzalloc`, and there's no corresponding `vb2_dma_contig_clear_max_seg_size()` call in `vdec_remove()`.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-06-04 5:48 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-30 9:42 [PATCH v6 0/8] media: meson: Fix memory leak in error path in vdec Anand Moon
2026-05-30 9:42 ` [PATCH v6 1/8] media: meson: vdec: Fix memory leaks and lifetime of m2m device Anand Moon
2026-06-04 5:48 ` Claude review: " Claude Code Review Bot
2026-05-30 9:42 ` [PATCH v6 2/8] media: meson: vdec: Fix concurrent STREAMON / STREAMOFF race conditions Anand Moon
2026-06-04 5:48 ` Claude review: " Claude Code Review Bot
2026-05-30 9:42 ` [PATCH v6 3/8] media: meson: vdec: Handle kthread failure and free codec state Anand Moon
2026-06-04 5:48 ` Claude review: " Claude Code Review Bot
2026-05-30 9:42 ` [PATCH v6 4/8] media: meson: vdec: Condition buffer flushing on queue type in start_streaming Anand Moon
2026-06-04 5:48 ` Claude review: " Claude Code Review Bot
2026-05-30 9:42 ` [PATCH v6 5/8] media: meson: vdec: Cancel esparser work during teardown Anand Moon
2026-06-04 5:48 ` Claude review: " Claude Code Review Bot
2026-05-30 9:42 ` [PATCH v6 6/8] media: meson: vdec: Configure DMA mask and segment size in probe Anand Moon
2026-06-04 5:48 ` Claude Code Review Bot [this message]
2026-05-30 9:42 ` [PATCH v6 7/8] media: meson: vdec: Fix NULL pointer dereference in ISR handlers Anand Moon
2026-06-04 5:48 ` Claude review: " Claude Code Review Bot
2026-05-30 9:42 ` [PATCH v6 8/8] gpu: drm: meson: Fix DMA max segment size for DMABUF imports Anand Moon
2026-06-04 5:48 ` Claude review: " Claude Code Review Bot
2026-06-04 5:48 ` Claude review: media: meson: Fix memory leak in error path in vdec Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch6-20260530094326.11892-7-linux.amoon@gmail.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox