public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/atomic: track individual colorop updates
Date: Thu, 04 Jun 2026 12:16:43 +1000	[thread overview]
Message-ID: <review-overall-20260602215743.914265-1-mwen@igalia.com> (raw)
In-Reply-To: <20260602215743.914265-1-mwen@igalia.com>

Overall Series Review

Subject: drm/atomic: track individual colorop updates
Author: Melissa Wen <mwen@igalia.com>
Patches: 5
Reviewed: 2026-06-04T12:16:43.925332

---

This is a clean, well-structured 4-patch bug-fix series at v8. It addresses two related issues in the DRM color pipeline (colorop) infrastructure:

1. **lut1d/lut3d interpolation properties were incorrectly treated as immutable** — stored on `drm_colorop` instead of `drm_colorop_state`, meaning changes from userspace went to the wrong place and weren't tracked per-atomic-state.

2. **Individual colorop property changes were not tracked** — changing a colorop property (bypass, curve type, LUT data, multiplier, interpolation) didn't set `plane_state->color_mgmt_changed`, so drivers had no way to know color blocks needed updating. This broke gamescope night-mode (shaper/3D-LUT updates).

The series is logically ordered: first fix docs (patch 1), then fix the data model (patch 2), then add change tracking in the core (patch 3), then wire it up in AMD's driver (patch 4). Each patch is independently correct, has appropriate Fixes tags, and carries reviewed-by tags from multiple reviewers (Intel, AMD). The code is straightforward, follows existing patterns, and I found no correctness bugs.

**Recommendation: This series looks ready to merge.**

---

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-06-04  2:16 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-02 21:53 [PATCH v8 0/4] drm/atomic: track individual colorop updates Melissa Wen
2026-06-02 21:53 ` [PATCH v8 1/4] drm/colorop: Remove read-only comments from interpolation fields Melissa Wen
2026-06-04  2:16   ` Claude review: " Claude Code Review Bot
2026-06-02 21:53 ` [PATCH v8 2/4] drm/colorop: make lut(1/3)d_interpolation props correctly behave as mutable Melissa Wen
2026-06-04  2:16   ` Claude review: " Claude Code Review Bot
2026-06-02 21:53 ` [PATCH v8 3/4] drm/atomic: track individual colorop updates Melissa Wen
2026-06-04  2:16   ` Claude review: " Claude Code Review Bot
2026-06-02 21:53 ` [PATCH v8 4/4] drm/amd/display: use plane color_mgmt_changed to track colorop changes Melissa Wen
2026-06-04  2:16   ` Claude review: " Claude Code Review Bot
2026-06-04  2:16 ` Claude Code Review Bot [this message]
  -- strict thread matches above, loose matches on Subject: below --
2026-05-25  9:49 [PATCH v7 0/4] drm/atomic: track individual colorop updates Melissa Wen
2026-05-25  9:50 ` [PATCH v7 3/4] " Melissa Wen
2026-05-25 21:18   ` Claude review: " Claude Code Review Bot
2026-05-25 21:18 ` Claude Code Review Bot
2026-05-19 21:09 [PATCH v6 0/6] " Melissa Wen
2026-05-19 21:09 ` [PATCH v6 5/6] " Melissa Wen
2026-05-25 12:24   ` Claude review: " Claude Code Review Bot
2026-05-25 12:24 ` Claude Code Review Bot
2026-05-06 19:23 [PATCH v5 0/6] " Melissa Wen
2026-05-06 19:23 ` [PATCH v5 5/6] " Melissa Wen
2026-05-07  3:05   ` Claude review: " Claude Code Review Bot
2026-05-07  3:05 ` Claude Code Review Bot
2026-05-01 13:06 [PATCH v4 0/6] drm/atomic: track colorop changes of a given plane Melissa Wen
2026-05-01 13:06 ` [PATCH v4 5/6] drm/atomic: track individual colorop updates Melissa Wen
2026-05-04 23:26   ` Claude review: " Claude Code Review Bot
2026-03-23 13:15 [PATCH v2 0/2] drm/atomic: track colorop changes of a given plane Melissa Wen
2026-03-23 13:15 ` [PATCH v2 1/2] drm/atomic: track individual colorop updates Melissa Wen
2026-03-24 21:51   ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-overall-20260602215743.914265-1-mwen@igalia.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox