public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/loongson: use managed KMS polling
Date: Sat, 16 May 2026 14:17:59 +1000	[thread overview]
Message-ID: <review-patch1-20260512063657.53100-1-mhun512@gmail.com> (raw)
In-Reply-To: <20260512063657.53100-1-mhun512@gmail.com>

Patch Review

**Analysis of the problem:**

Looking at the current `lsdc_pci_probe()` (line 296), `drm_kms_helper_poll_init(ddev)` is called, but there are three subsequent failure paths (lines 300, 309, 316) that all `return ret` without finalizing polling. The `lsdc_pci_remove()` function (line 324-330) also lacks a `drm_kms_helper_poll_fini()` call:

```c
static void lsdc_pci_remove(struct pci_dev *pdev)
{
	struct drm_device *ddev = pci_get_drvdata(pdev);

	drm_dev_unregister(ddev);
	drm_atomic_helper_shutdown(ddev);
}
```

**The fix:**

```diff
-	drm_kms_helper_poll_init(ddev);
+	drmm_kms_helper_poll_init(ddev);
```

This is the right approach. The managed function internally calls `drm_kms_helper_poll_init()` and then registers a cleanup action via `drmm_add_action_or_reset()`, so no manual `drm_kms_helper_poll_fini()` calls are needed in error paths or remove/shutdown.

**No issues found.** The function signature is `void drmm_kms_helper_poll_init(struct drm_device *dev)` — same as the non-managed version — so the one-line substitution is a complete fix.

The Fixes tag and Cc: stable are appropriate since this is a real resource leak present since the driver was introduced.

**Reviewed-by recommendation:** This patch is ready to merge.

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-05-16  4:17 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-12  6:36 [PATCH v2] drm/loongson: use managed KMS polling Myeonghun Pak
2026-05-12  6:40 ` Thomas Zimmermann
2026-05-12  7:55 ` Jianmin Lv
2026-05-12  8:11 ` Huacai Chen
2026-05-13  6:56   ` Myeonghun Pak
2026-05-16  4:17 ` Claude review: " Claude Code Review Bot
2026-05-16  4:17 ` Claude Code Review Bot [this message]
  -- strict thread matches above, loose matches on Subject: below --
2026-05-12  6:53 [PATCH v2] " Myeonghun Pak
2026-05-16  4:07 ` Claude review: " Claude Code Review Bot
2026-05-16  4:07 ` Claude Code Review Bot
2026-05-13  6:57 [PATCH v3] drm/loongson: Use " Myeonghun Pak
2026-05-16  2:30 ` Claude review: " Claude Code Review Bot
2026-05-16  2:30 ` Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260512063657.53100-1-mhun512@gmail.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox