public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/loongson: use managed KMS polling
Date: Sat, 16 May 2026 14:07:27 +1000	[thread overview]
Message-ID: <review-patch1-20260512065436.74729-1-mhun512@gmail.com> (raw)
In-Reply-To: <20260512065436.74729-1-mhun512@gmail.com>

Patch Review

**Code change:**

```c
-	drm_kms_helper_poll_init(ddev);
+	drmm_kms_helper_poll_init(ddev);
```

This is a clean one-line substitution. `drmm_kms_helper_poll_init()` is the established managed wrapper (already used by `ast`, `hibmc`, and `udl` drivers in the tree), and it registers a cleanup action via `drmm_add_action_or_reset()` so that `drm_kms_helper_poll_fini()` is called automatically when the DRM device is released.

**Correctness:** The switch is safe here. `drmm_kms_helper_poll_init()` has the same signature (takes only `struct drm_device *`). The managed cleanup will run after `drm_dev_unregister()` tears down the device, which is the correct ordering — polling should be finalized after the device is unregistered, and the `drmm` action ordering guarantees this since the poll_init action is registered before `drm_dev_register()`.

**Minor observation:** The commit message and Fixes tag are appropriate. The `Cc: stable` tag is reasonable since this is a resource leak on error paths that has existed since the driver was introduced. The Co-developed-by / Signed-off-by chain is correctly formatted.

**No issues found.** 

Reviewed-by worthy as-is.

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-05-16  4:07 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-12  6:53 [PATCH v2] drm/loongson: use managed KMS polling Myeonghun Pak
2026-05-12  6:56 ` Myeonghun Pak
2026-05-16  4:07 ` Claude review: " Claude Code Review Bot
2026-05-16  4:07 ` Claude Code Review Bot [this message]
  -- strict thread matches above, loose matches on Subject: below --
2026-05-13  6:57 [PATCH v3] drm/loongson: Use " Myeonghun Pak
2026-05-16  2:30 ` Claude review: " Claude Code Review Bot
2026-05-16  2:30 ` Claude Code Review Bot
2026-05-12  6:36 [PATCH v2] drm/loongson: use " Myeonghun Pak
2026-05-16  4:17 ` Claude review: " Claude Code Review Bot
2026-05-16  4:17 ` Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260512065436.74729-1-mhun512@gmail.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox