public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/loongson: Use managed KMS polling
Date: Sat, 16 May 2026 12:30:12 +1000	[thread overview]
Message-ID: <review-overall-20260513065706.23803-1-mhun512@gmail.com> (raw)
In-Reply-To: <20260513065706.23803-1-mhun512@gmail.com>

Overall Series Review

Subject: drm/loongson: Use managed KMS polling
Author: Myeonghun Pak <mhun512@gmail.com>
Patches: 1
Reviewed: 2026-05-16T12:30:12.889221

---

This is a single-patch series that replaces `drm_kms_helper_poll_init()` with its managed counterpart `drmm_kms_helper_poll_init()` in the loongson LSDC driver. The change is correct, well-motivated, and has already been reviewed/acked by the relevant maintainers.

**Assessment: Good to merge.**

The commit message clearly identifies the problem: `drm_kms_helper_poll_init()` is called early in probe, but if later steps (`drm_vblank_init`, `devm_request_irq`, `drm_dev_register`) fail, the driver returns without calling `drm_kms_helper_poll_fini()`. Additionally, `lsdc_pci_remove()` (line 324-330 in the current tree) never calls `drm_kms_helper_poll_fini()` either — it only does `drm_dev_unregister()` and `drm_atomic_helper_shutdown()`. Using `drmm_kms_helper_poll_init()` ties the polling lifecycle to the DRM device managed cleanup, fixing both the error-path leak and the missing finalization on removal.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-05-16  2:30 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-13  6:57 [PATCH v3] drm/loongson: Use managed KMS polling Myeonghun Pak
2026-05-16  2:30 ` Claude Code Review Bot [this message]
2026-05-16  2:30 ` Claude review: " Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-05-12  6:53 [PATCH v2] drm/loongson: use " Myeonghun Pak
2026-05-16  4:07 ` Claude review: " Claude Code Review Bot
2026-05-16  4:07 ` Claude Code Review Bot
2026-05-12  6:36 [PATCH v2] " Myeonghun Pak
2026-05-16  4:17 ` Claude review: " Claude Code Review Bot
2026-05-16  4:17 ` Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-overall-20260513065706.23803-1-mhun512@gmail.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox