From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/loongson: use managed KMS polling
Date: Sat, 16 May 2026 14:07:27 +1000 [thread overview]
Message-ID: <review-overall-20260512065436.74729-1-mhun512@gmail.com> (raw)
In-Reply-To: <20260512065436.74729-1-mhun512@gmail.com>
Overall Series Review
Subject: drm/loongson: use managed KMS polling
Author: Myeonghun Pak <mhun512@gmail.com>
Patches: 2
Reviewed: 2026-05-16T14:07:27.468757
---
This is a single-patch series that replaces `drm_kms_helper_poll_init()` with its managed counterpart `drmm_kms_helper_poll_init()` in the loongson display controller driver. The fix is correct and well-motivated.
**The problem is real:** `lsdc_pci_probe()` calls `drm_kms_helper_poll_init()` at line 296, but if subsequent steps fail (`drm_vblank_init`, `devm_request_irq`, or `drm_dev_register`), the function returns without calling `drm_kms_helper_poll_fini()`. Furthermore, `lsdc_pci_remove()` also never calls `drm_kms_helper_poll_fini()`, so polling is never finalized even on normal device removal. The managed variant ties the polling lifecycle to the DRM device and handles cleanup automatically.
**Verdict: Patch looks good.** One minor observation below.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-16 4:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-12 6:53 [PATCH v2] drm/loongson: use managed KMS polling Myeonghun Pak
2026-05-12 6:56 ` Myeonghun Pak
2026-05-16 4:07 ` Claude review: " Claude Code Review Bot
2026-05-16 4:07 ` Claude Code Review Bot [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-05-13 6:57 [PATCH v3] drm/loongson: Use " Myeonghun Pak
2026-05-16 2:30 ` Claude review: " Claude Code Review Bot
2026-05-16 2:30 ` Claude Code Review Bot
2026-05-12 6:36 [PATCH v2] drm/loongson: use " Myeonghun Pak
2026-05-16 4:17 ` Claude review: " Claude Code Review Bot
2026-05-16 4:17 ` Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260512065436.74729-1-mhun512@gmail.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox