public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/loongson: Use managed KMS polling
Date: Sat, 16 May 2026 12:30:13 +1000	[thread overview]
Message-ID: <review-patch1-20260513065706.23803-1-mhun512@gmail.com> (raw)
In-Reply-To: <20260513065706.23803-1-mhun512@gmail.com>

Patch Review

**Correctness: No issues.**

The change from:
```c
-	drm_kms_helper_poll_init(ddev);
+	drmm_kms_helper_poll_init(ddev);
```

is the right fix. `drmm_kms_helper_poll_init()` is declared in `drm/drm_probe_helper.h` and registers a managed cleanup action via `drmm_add_action_or_reset()`, so `drm_kms_helper_poll_fini()` is called automatically when the DRM device is released.

Looking at the probe function, the error paths at lines 300-301 and 308-310 return directly without any cleanup of the poll init — this patch fixes those leaks. The removal path in `lsdc_pci_remove()` also lacks a `drm_kms_helper_poll_fini()` call, which is likewise fixed by this change.

**Tags:** The patch has appropriate `Fixes:`, `Cc: stable`, `Reviewed-by` (Thomas Zimmermann, Huacai Chen), and `Acked-by` (Jianmin Lv) tags.

**Nit (non-blocking):** The return type of `drmm_kms_helper_poll_init()` is `void`, so there's no error to check — the current usage is correct.

**Verdict: Looks good.** No changes needed.

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-05-16  2:30 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-13  6:57 [PATCH v3] drm/loongson: Use managed KMS polling Myeonghun Pak
2026-05-16  2:30 ` Claude review: " Claude Code Review Bot
2026-05-16  2:30 ` Claude Code Review Bot [this message]
  -- strict thread matches above, loose matches on Subject: below --
2026-05-12  6:53 [PATCH v2] drm/loongson: use " Myeonghun Pak
2026-05-16  4:07 ` Claude review: " Claude Code Review Bot
2026-05-16  4:07 ` Claude Code Review Bot
2026-05-12  6:36 [PATCH v2] " Myeonghun Pak
2026-05-16  4:17 ` Claude review: " Claude Code Review Bot
2026-05-16  4:17 ` Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260513065706.23803-1-mhun512@gmail.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox