From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/msm/adreno: rename llc_mmio to cx_misc_mmio
Date: Tue, 05 May 2026 08:55:16 +1000 [thread overview]
Message-ID: <review-patch3-20260502-adreno-810-v5-3-bc9fd2bb788d@pm.me> (raw)
In-Reply-To: <20260502-adreno-810-v5-3-bc9fd2bb788d@pm.me>
Patch Review
**Status: Looks good**
Straightforward mechanical rename of `llc_mmio` → `cx_misc_mmio` and the accessor functions `a6xx_llc_read/write/rmw` → `a6xx_cx_misc_read/write/rmw`. The rename is well-motivated: the CX_MISC region is used for more than just LLCC (software fuses, TCM retention, slice info, speedbin softfuse), so the name was misleading.
The rename covers all files consistently:
- `a6xx_gpu.h`: struct field and inline accessor functions
- `a6xx_gpu.c`: all call sites in `a6xx_llc_activate`, `a7xx_llc_activate`, `a6xx_llc_slices_init`, `a6xx_read_speedbin`
- `a6xx_gmu.c`: TCM retention, SW fuse, cold/warm boot detection
- `a8xx_gpu.c`: slice enable readback
Has `Reviewed-by` from Akhil P Oommen and Konrad Dybcio.
No issues found.
---
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-04 22:55 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-02 8:07 [PATCH RFC v5 0/7] Add support for Adreno 810 GPU Alexander Koskovich
2026-05-02 8:07 ` [PATCH RFC v5 1/7] dt-bindings: display/msm/gmu: Document Adreno 810 GMU Alexander Koskovich
2026-05-04 22:55 ` Claude review: " Claude Code Review Bot
2026-05-02 8:07 ` [PATCH RFC v5 2/7] dt-bindings: display/msm/gpu: Document A810 GPU Alexander Koskovich
2026-05-04 22:55 ` Claude review: " Claude Code Review Bot
2026-05-02 8:08 ` [PATCH RFC v5 3/7] drm/msm/adreno: rename llc_mmio to cx_misc_mmio Alexander Koskovich
2026-05-04 22:55 ` Claude Code Review Bot [this message]
2026-05-02 8:08 ` [PATCH RFC v5 4/7] drm/msm/adreno: set cx_misc_mmio regardless of if platform has LLCC Alexander Koskovich
2026-05-04 22:55 ` Claude review: " Claude Code Review Bot
2026-05-02 8:08 ` [PATCH RFC v5 5/7] drm/msm/a8xx: use pipe protect slot 15 for last-span-unbound feature Alexander Koskovich
2026-05-04 22:55 ` Claude review: " Claude Code Review Bot
2026-05-02 8:08 ` [PATCH RFC v5 6/7] drm/msm/adreno: add Adreno 810 GPU support Alexander Koskovich
2026-05-04 22:55 ` Claude review: " Claude Code Review Bot
2026-05-02 8:08 ` [PATCH RFC v5 7/7] arm64: dts: qcom: milos: Add Adreno 810 GPU and GMU nodes Alexander Koskovich
2026-05-04 22:55 ` Claude review: " Claude Code Review Bot
2026-05-04 22:55 ` Claude review: Add support for Adreno 810 GPU Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-04-08 1:45 [PATCH RFC v3 0/7] " Alexander Koskovich
2026-04-08 1:45 ` [PATCH RFC v3 3/7] drm/msm/adreno: rename llc_mmio to cx_misc_mmio Alexander Koskovich
2026-04-12 3:17 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch3-20260502-adreno-810-v5-3-bc9fd2bb788d@pm.me \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox