Claude review: Add support for Adreno 810 GPU

[Claude Code Review Bot <claude-review@example.com>]

Overall Series Review

Subject: Add support for Adreno 810 GPU
Author: Alexander Koskovich <akoskovich@pm.me>
Patches: 8
Reviewed: 2026-05-05T08:55:16.085792

---

This is a well-structured 7-patch series adding Adreno 810 GPU support (Qualcomm SM7635/Milos) to the MSM DRM driver. The series is logically ordered: dt-bindings first, then preparatory refactoring (rename `llc_mmio` to `cx_misc_mmio`, decouple cx_misc from LLCC), a targeted fix for pipe protect slot indexing, the main GPU catalog entry, and finally the device tree node.

The preparatory patches (3 and 4) are the most architecturally significant — they fix a real problem where platforms without LLCC (like Milos) would crash because `cx_misc_mmio` was tied to LLCC slice availability. The approach is clean and correct.

**One notable concern**: Patch 5 hardcodes pipe protect slot 15 to fix an out-of-bounds issue caused by `count_max` having dual semantics (global protect slot count vs. pipe slot index). While the fix is correct and matches downstream, it papers over the underlying API confusion. The `count_max` field is used as a slot index in `a8xx_set_cp_protect()` but as a capacity limit elsewhere — this should eventually be cleaned up.

The series has Reviewed-by tags from Qualcomm engineers (Akhil P Oommen, Konrad Dybcio) on most patches, and dt-bindings have Krzysztof Kozlowski's review. Patch 6 (the main catalog entry) and patch 7 (DTS) lack driver maintainer Reviewed-by tags but have been through 5 revisions.

Overall: series looks ready for merge once dependencies land.

---

---
Generated by Claude Code Patch Reviewer