From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/msm/adreno: rename llc_mmio to cx_misc_mmio
Date: Sat, 16 May 2026 10:05:41 +1000 [thread overview]
Message-ID: <review-patch3-20260515-adreno-810-v6-3-fbe04c7203e1@pm.me> (raw)
In-Reply-To: <20260515-adreno-810-v6-3-fbe04c7203e1@pm.me>
Patch Review
**Status: Looks good**
Purely mechanical rename: `llc_mmio` → `cx_misc_mmio`, `a6xx_llc_read/write/rmw` → `a6xx_cx_misc_read/write/rmw`. The rename is well-motivated — this region provides access to software fuse values and other CX_MISC registers, not just LLC configuration.
The rename is complete across all files (a6xx_gmu.c, a6xx_gpu.c, a6xx_gpu.h, a8xx_gpu.c). Has reviews from both Akhil P Oommen and Konrad Dybcio.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-16 0:05 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-15 5:08 [PATCH RFC v6 0/7] Add support for Adreno 810 GPU Alexander Koskovich
2026-05-15 5:08 ` [PATCH RFC v6 1/7] dt-bindings: display/msm/gmu: Document Adreno 810 GMU Alexander Koskovich
2026-05-16 0:05 ` Claude review: " Claude Code Review Bot
2026-05-15 5:08 ` [PATCH RFC v6 2/7] dt-bindings: display/msm/gpu: Document Adreno 810 GPU Alexander Koskovich
2026-05-16 0:05 ` Claude review: " Claude Code Review Bot
2026-05-15 5:08 ` [PATCH RFC v6 3/7] drm/msm/adreno: rename llc_mmio to cx_misc_mmio Alexander Koskovich
2026-05-16 0:05 ` Claude Code Review Bot [this message]
2026-05-15 5:08 ` [PATCH RFC v6 4/7] drm/msm/adreno: set cx_misc_mmio regardless of if platform has LLCC Alexander Koskovich
2026-05-16 0:05 ` Claude review: " Claude Code Review Bot
2026-05-15 5:09 ` [PATCH RFC v6 5/7] drm/msm/a8xx: use pipe protect slot 15 for last-span-unbound feature Alexander Koskovich
2026-05-16 0:05 ` Claude review: " Claude Code Review Bot
2026-05-15 5:09 ` [PATCH RFC v6 6/7] drm/msm/adreno: add Adreno 810 GPU support Alexander Koskovich
2026-05-16 0:05 ` Claude review: " Claude Code Review Bot
2026-05-15 5:09 ` [PATCH RFC v6 7/7] arm64: dts: qcom: milos: Add Adreno 810 GPU and GMU nodes Alexander Koskovich
2026-05-16 0:05 ` Claude review: " Claude Code Review Bot
2026-05-15 22:22 ` [PATCH RFC v6 0/7] Add support for Adreno 810 GPU Akhil P Oommen
2026-05-16 0:05 ` Claude review: " Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-05-02 8:07 [PATCH RFC v5 0/7] " Alexander Koskovich
2026-05-02 8:08 ` [PATCH RFC v5 3/7] drm/msm/adreno: rename llc_mmio to cx_misc_mmio Alexander Koskovich
2026-05-04 22:55 ` Claude review: " Claude Code Review Bot
2026-04-08 1:45 [PATCH RFC v3 0/7] Add support for Adreno 810 GPU Alexander Koskovich
2026-04-08 1:45 ` [PATCH RFC v3 3/7] drm/msm/adreno: rename llc_mmio to cx_misc_mmio Alexander Koskovich
2026-04-12 3:17 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch3-20260515-adreno-810-v6-3-fbe04c7203e1@pm.me \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox