public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: arm64: dts: ti: k3-am62-verdin: Add Toradex OV5640 CSI Cameras
Date: Mon, 25 May 2026 18:25:02 +1000	[thread overview]
Message-ID: <review-patch9-20260522161105.277519-22-ivitro@gmail.com> (raw)
In-Reply-To: <20260522161105.277519-22-ivitro@gmail.com>

Patch Review

Good use of a shared `.dtsi` file with two thin `.dtso` wrappers that only override `clock-frequency` (27 MHz vs 24 MHz). Clean factoring.

- The `clk_ov5640_osc` fixed-clock node is defined without a `clock-frequency` — it must be set by the including `.dtso`. This works because overlays are compiled as complete units, and the `.dtsi` is included into the `.dtso` before compilation.

- The `regulator_camera` uses `gpio = <&main_gpio0 42 GPIO_ACTIVE_HIGH>` with `enable-active-high` — correct for a GPIO-controlled power switch.

- All three OV5640 supply rails (`AVDD`, `DOVDD`, `DVDD`) point to `&regulator_camera`. This is a simplification — the OV5640 datasheet specifies different voltages for each rail (2.8V analog, 1.8V IO, 1.5V digital core). This is common in DTS for modules where a single power control GPIO gates all rails through the module's on-board regulators.

- The camera endpoint specifies `data-lanes = <1 2>` (2-lane CSI-2) and `bus-type = <4>` (CSI-2 D-PHY) on both sides of the link. Correct.

**No issues.**

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-05-25  8:25 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-22 16:11 [PATCH v3 00/11] arm64: dts: ti: k3-am62-verdin: Add display and peripheral overlays Vitor Soares
2026-05-22 16:11 ` [PATCH v3 01/11] arm64: dts: ti: k3-am62-verdin: Add Toradex DSI to LVDS adapter with 10.1" display Vitor Soares
2026-05-25  8:25   ` Claude review: " Claude Code Review Bot
2026-05-22 16:11 ` [PATCH v3 02/11] arm64: dts: ti: k3-am62-verdin: Add Toradex Capacitive Touch Display 10.1" LVDS Vitor Soares
2026-05-25  8:25   ` Claude review: " Claude Code Review Bot
2026-05-22 16:11 ` [PATCH v3 03/11] dt-bindings: vendor-prefixes: Add Riverdi Vitor Soares
2026-05-25  8:25   ` Claude review: " Claude Code Review Bot
2026-05-22 16:11 ` [PATCH v3 04/11] dt-bindings: display: panel-lvds: Add Riverdi RVT70HSLNWCA0 and RVT101HVLNWC00 Vitor Soares
2026-05-25  8:25   ` Claude review: " Claude Code Review Bot
2026-05-22 16:11 ` [PATCH v3 05/11] arm64: dts: ti: k3-am62-verdin: Add Toradex Capacitive Touch Display 10.1" DSI Vitor Soares
2026-05-25  8:25   ` Claude review: " Claude Code Review Bot
2026-05-22 16:11 ` [PATCH v3 06/11] arm64: dts: ti: k3-am62-verdin: Add Toradex Capacitive Touch Display 7" DSI Vitor Soares
2026-05-25  8:25   ` Claude review: " Claude Code Review Bot
2026-05-22 16:11 ` [PATCH v3 07/11] arm64: dts: ti: k3-am62-verdin: Add NAU8822 Bridge Tied Load Vitor Soares
2026-05-25  8:25   ` Claude review: " Claude Code Review Bot
2026-05-22 16:11 ` [PATCH v3 08/11] arm64: dts: ti: k3-am62-verdin: Reserve UART_4 for Cortex-M4F Vitor Soares
2026-05-25  8:25   ` Claude review: " Claude Code Review Bot
2026-05-22 16:11 ` [PATCH v3 09/11] arm64: dts: ti: k3-am62-verdin: Add Toradex OV5640 CSI Cameras Vitor Soares
2026-05-25  8:25   ` Claude Code Review Bot [this message]
2026-05-22 16:11 ` [PATCH v3 10/11] arm64: dts: ti: k3-am62-verdin: Add Toradex Verdin Mezzanine CAN Vitor Soares
2026-05-25  8:25   ` Claude review: " Claude Code Review Bot
2026-05-22 16:11 ` [PATCH v3 11/11] arm64: dts: ti: k3-am62-verdin: Add Mezzanine with Toradex Display 10.1" LVDS Vitor Soares
2026-05-25  8:25   ` Claude review: " Claude Code Review Bot
2026-05-22 17:05 ` [PATCH v3 00/11] arm64: dts: ti: k3-am62-verdin: Add display and peripheral overlays Francesco Dolcini
2026-05-25  8:25 ` Claude review: " Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-05-21 15:00 [PATCH v1 00/15] " Vitor Soares
2026-05-21 15:00 ` [PATCH v1 10/15] arm64: dts: ti: k3-am62-verdin: Add Toradex OV5640 CSI Cameras Vitor Soares
2026-05-25  9:56   ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch9-20260522161105.277519-22-ivitro@gmail.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox