[PATCH] drm/ipv3: add CONFIG_OF dependency for DRM_OF_DISPLAY_MODE_BRIDGE

[PATCH] drm/ipv3: add CONFIG_OF dependency for DRM_OF_DISPLAY_MODE_BRIDGE

[Arnd Bergmann]

From: Arnd Bergmann <arnd@arndb.de>

Without this, not all dependencies are met here.

  Depends on [n]: HAS_IOMEM [=y] && DRM [=y] && DRM_BRIDGE [=y] && OF [=n]
  Selected by [y]:
  - DRM_IMX_PARALLEL_DISPLAY [=y] && HAS_IOMEM [=y] && DRM [=y] && DRM_IMX [=y]
  - DRM_IMX_LDB [=y] && HAS_IOMEM [=y] && DRM [=y] && DRM_IMX [=y] && COMMON_CLK [=y]

Fixes: ba2db93cf3d5 ("drm/bridge: Move legacy bridge driver out of imx directory for multi-platform use")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/gpu/drm/imx/ipuv3/Kconfig | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/gpu/drm/imx/ipuv3/Kconfig b/drivers/gpu/drm/imx/ipuv3/Kconfig
index 351dc65913eb..3ca237515e46 100644
--- a/drivers/gpu/drm/imx/ipuv3/Kconfig
+++ b/drivers/gpu/drm/imx/ipuv3/Kconfig
@@ -13,6 +13,7 @@ config DRM_IMX
 config DRM_IMX_PARALLEL_DISPLAY
 	tristate "Support for parallel displays"
 	depends on DRM_IMX
+	depends on OF
 	select DRM_BRIDGE
 	select DRM_BRIDGE_CONNECTOR
 	select DRM_DISPLAY_HELPER
@@ -33,6 +34,7 @@ config DRM_IMX_LDB
 	tristate "Support for LVDS displays"
 	depends on DRM_IMX
 	depends on COMMON_CLK
+	depends on OF
 	select MFD_SYSCON
 	select DRM_BRIDGE
 	select DRM_BRIDGE_CONNECTOR
-- 
2.39.5

Re: [PATCH] drm/ipv3: add CONFIG_OF dependency for DRM_OF_DISPLAY_MODE_BRIDGE

[Luca Ceresoli]

On Wed Apr 29, 2026 at 4:00 PM CEST, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> Without this, not all dependencies are met here.
>
>   Depends on [n]: HAS_IOMEM [=y] && DRM [=y] && DRM_BRIDGE [=y] && OF [=n]
>   Selected by [y]:
>   - DRM_IMX_PARALLEL_DISPLAY [=y] && HAS_IOMEM [=y] && DRM [=y] && DRM_IMX [=y]
>   - DRM_IMX_LDB [=y] && HAS_IOMEM [=y] && DRM [=y] && DRM_IMX [=y] && COMMON_CLK [=y]
>
> Fixes: ba2db93cf3d5 ("drm/bridge: Move legacy bridge driver out of imx directory for multi-platform use")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>

--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

Re: [PATCH] drm/ipv3: add CONFIG_OF dependency for DRM_OF_DISPLAY_MODE_BRIDGE

[Damon Ding]

On 4/30/2026 3:17 PM, Luca Ceresoli wrote:
> On Wed Apr 29, 2026 at 4:00 PM CEST, Arnd Bergmann wrote:
>> From: Arnd Bergmann <arnd@arndb.de>
>>
>> Without this, not all dependencies are met here.
>>
>>    Depends on [n]: HAS_IOMEM [=y] && DRM [=y] && DRM_BRIDGE [=y] && OF [=n]
>>    Selected by [y]:
>>    - DRM_IMX_PARALLEL_DISPLAY [=y] && HAS_IOMEM [=y] && DRM [=y] && DRM_IMX [=y]
>>    - DRM_IMX_LDB [=y] && HAS_IOMEM [=y] && DRM [=y] && DRM_IMX [=y] && COMMON_CLK [=y]
>>
>> Fixes: ba2db93cf3d5 ("drm/bridge: Move legacy bridge driver out of imx directory for multi-platform use")
>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> 
> Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
> 
> 

Reviewed-by: Damon Ding <damon.ding@rock-chips.com>

Best regards,
Damon

Re: [PATCH] drm/ipv3: add CONFIG_OF dependency for DRM_OF_DISPLAY_MODE_BRIDGE

[Luca Ceresoli]

On Wed, 29 Apr 2026 16:00:11 +0200, Arnd Bergmann wrote:
> Without this, not all dependencies are met here.
> 
>   Depends on [n]: HAS_IOMEM [=y] && DRM [=y] && DRM_BRIDGE [=y] && OF [=n]
>   Selected by [y]:
>   - DRM_IMX_PARALLEL_DISPLAY [=y] && HAS_IOMEM [=y] && DRM [=y] && DRM_IMX [=y]
>   - DRM_IMX_LDB [=y] && HAS_IOMEM [=y] && DRM [=y] && DRM_IMX [=y] && COMMON_CLK [=y]
> 
> [...]

Applied, thanks!

[1/1] drm/ipv3: add CONFIG_OF dependency for DRM_OF_DISPLAY_MODE_BRIDGE
      commit: 528578941a240e0916942bbb5b910c57bbfb3614

Best regards,
-- 
Luca Ceresoli <luca.ceresoli@bootlin.com>

Claude review: drm/ipv3: add CONFIG_OF dependency for DRM_OF_DISPLAY_MODE_BRIDGE

[Claude Code Review Bot]

Overall Series Review

Subject: drm/ipv3: add CONFIG_OF dependency for DRM_OF_DISPLAY_MODE_BRIDGE
Author: Arnd Bergmann <arnd@kernel.org>
Patches: 4
Reviewed: 2026-05-05T11:36:17.719753

---

This is a single patch from Arnd Bergmann fixing a Kconfig dependency issue where `DRM_OF_DISPLAY_MODE_BRIDGE` (which depends on `OF`) gets force-selected by `DRM_IMX_PARALLEL_DISPLAY` and `DRM_IMX_LDB` even when `OF` is disabled (reachable via `COMPILE_TEST`). The Kconfig `select` mechanism notoriously overrides `depends on`, so the selecting symbols must carry the dependency themselves.

The fix is correct and the standard approach for this class of Kconfig problem. The patch is minimal and well-targeted.

**Note:** This patch does not apply cleanly to the current drm-next tree. In drm-next, the `DRM_OF_DISPLAY_MODE_BRIDGE` symbol has already been renamed to `DRM_IMX_LEGACY_BRIDGE`, and that renamed config no longer carries a `depends on OF` (only `depends on DRM_IMX`). However, `DRM_IMX_LEGACY_BRIDGE` still uses `of_get_drm_display_mode()` per its own help text, so the underlying issue may persist in a different form on drm-next — the OF dependency was apparently dropped during the rename rather than being pushed to the callers. The patch is presumably targeting the tree where `DRM_OF_DISPLAY_MODE_BRIDGE` still exists.

---
Generated by Claude Code Patch Reviewer

Claude review: drm/ipv3: add CONFIG_OF dependency for DRM_OF_DISPLAY_MODE_BRIDGE

[Claude Code Review Bot]

Patch Review

**Subject line typo:** The subsystem prefix is `drm/ipv3` but should be `drm/ipuv3` (missing the "u"). The Kconfig and directory are both `ipuv3`.

**Commit message:** Clear and well-structured. The Kconfig dependency resolution output pasted in the body immediately makes the problem obvious:
```
Depends on [n]: HAS_IOMEM [=y] && DRM [=y] && DRM_BRIDGE [=y] && OF [=n]
Selected by [y]:
- DRM_IMX_PARALLEL_DISPLAY [=y] && ...
- DRM_IMX_LDB [=y] && ...
```

**Code changes — correct and minimal:**

```diff
 config DRM_IMX_PARALLEL_DISPLAY
 	tristate "Support for parallel displays"
 	depends on DRM_IMX
+	depends on OF
```

```diff
 config DRM_IMX_LDB
 	tristate "Support for LVDS displays"
 	depends on DRM_IMX
 	depends on COMMON_CLK
+	depends on OF
```

Both additions are correct. The dependency chain that enables the `OF=n` path is: `COMPILE_TEST` → `IMX_IPUV3_CORE` → `DRM_IMX` → `DRM_IMX_PARALLEL_DISPLAY`/`DRM_IMX_LDB` → (selects) `DRM_OF_DISPLAY_MODE_BRIDGE`, and `DRM_OF_DISPLAY_MODE_BRIDGE` depends on `OF`. Adding `depends on OF` to the selectors prevents the broken configuration.

**Minor observations:**

1. `DRM_IMX_HDMI` in the same file already has `depends on DRM_IMX && OF`, so there is precedent for per-sub-option OF dependencies here.

2. An alternative approach would be to add `depends on OF` to `DRM_IMX` itself, which would cascade to all sub-options. This would be cleaner if all sub-options require OF (which seems likely for an i.MX DRM driver), but would also affect `DRM_IMX_TVE` which currently has no OF dependency. The per-option approach in this patch is the safer, more targeted fix.

**Verdict:** The fix is correct. The subject typo (`ipv3` → `ipuv3`) should be fixed before applying.

---
Generated by Claude Code Patch Reviewer