Claude review: qcom: Refactor GPU GX GDSC handling and IFPC behavior on A8x GPUs

[Claude Code Review Bot <claude-review@example.com>]

Overall Series Review

Subject: qcom: Refactor GPU GX GDSC handling and IFPC behavior on A8x GPUs
Author: Taniya Das <taniya.das@oss.qualcomm.com>
Patches: 17
Reviewed: 2026-04-12T13:46:54.677976

---

This series addresses two real problems with GX GDSC ownership and rail voting on A8x (Kaanapali) GPUs. The cover letter is well-written and clearly explains both problem statements and their solutions. The approach of using `synced_poweroff` as a gate for OS-side GX collapse is sound and follows the existing pattern used for CX PD in the recovery path.

There are a few issues worth addressing:

1. **Missing `#else` stub in gdsc.h** (Patch 1) will cause build failures when `CONFIG_QCOM_GDSC` is not set.
2. **Patch 3 has broader scope than motivated** -- it changes behavior for all `use_rpm` clock controllers, not just gxclkctl.
3. **Unchecked `pm_runtime_get_sync()` return value** in Patch 6's `a6xx_gmu_gxpd_put()`.
4. **Ordering difference with a6xx_recover** in Patch 5, despite claiming to match that behavior.

---

---
Generated by Claude Code Patch Reviewer