public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: clk: qcom: gxclkctl: Remove GX/GMxC rail votes to align with IFPC
Date: Sun, 12 Apr 2026 13:46:55 +1000	[thread overview]
Message-ID: <review-patch4-20260407-gfx-clk-fixes-v1-4-4bb5583a5054@oss.qualcomm.com> (raw)
In-Reply-To: <20260407-gfx-clk-fixes-v1-4-4bb5583a5054@oss.qualcomm.com>

Patch Review

```c
+	ret = qcom_cc_probe(pdev, &gx_clkctl_kaanapali_desc);
+	if (ret)
+		return ret;
+
+	pm_runtime_disable(&pdev->dev);
+
+	return ret;
```

The approach of disabling runtime PM post-probe to prevent RPM request propagation from GMU's device links is reasonable.

**Minor:** `return ret;` where `ret` is guaranteed to be 0 -- `return 0;` would be marginally clearer, though this is a style nit.

**Concern: No cleanup path.** If the module is unbound/rebound, `pm_runtime_disable()` is called again on an already-disabled device. The PM core handles this gracefully (it's ref-counted via `disable_depth`), but repeated unload/reload could keep incrementing `disable_depth`. Since there's no `.remove` callback, there's no matching `pm_runtime_enable()`. This is probably fine in practice since this driver is essentially always-loaded, but worth noting.

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-04-12  3:46 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-07  9:30 [PATCH 0/6] qcom: Refactor GPU GX GDSC handling and IFPC behavior on A8x GPUs Taniya Das
2026-04-07  9:30 ` [PATCH 1/6] clk: qcom: gdsc: Add custom disable callback for GX GDSC Taniya Das
2026-04-07 10:56   ` Konrad Dybcio
2026-04-08  7:26     ` Taniya Das
2026-04-12  3:46   ` Claude review: " Claude Code Review Bot
2026-04-07  9:30 ` [PATCH 2/6] clk: qcom: gxclkctl: Use custom disable callback for gx_gdsc Taniya Das
2026-04-07 10:56   ` Konrad Dybcio
2026-04-12  3:46   ` Claude review: " Claude Code Review Bot
2026-04-07  9:30 ` [PATCH 3/6] clk: qcom: common: ensure runtime PM suspend completes on probe Taniya Das
2026-04-07 10:58   ` Konrad Dybcio
2026-04-08  7:26     ` Taniya Das
2026-04-12  3:46   ` Claude review: " Claude Code Review Bot
2026-04-07  9:30 ` [PATCH 4/6] clk: qcom: gxclkctl: Remove GX/GMxC rail votes to align with IFPC Taniya Das
2026-04-07 11:29   ` Konrad Dybcio
2026-04-08  7:25     ` Taniya Das
2026-04-12  3:46   ` Claude Code Review Bot [this message]
2026-04-07  9:30 ` [PATCH 5/6] drm/msm/a8xx: Make a8xx_recover IFPC safe Taniya Das
2026-04-07 11:00   ` Konrad Dybcio
2026-04-12  3:46   ` Claude review: " Claude Code Review Bot
2026-04-07  9:30 ` [PATCH 6/6] drm/msm/a6xx: Limit GXPD votes to recovery in A8x Taniya Das
2026-04-07 11:01   ` Konrad Dybcio
2026-04-07 19:16     ` Akhil P Oommen
2026-04-12  3:46   ` Claude review: " Claude Code Review Bot
2026-04-12  3:46 ` Claude review: qcom: Refactor GPU GX GDSC handling and IFPC behavior on A8x GPUs Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch4-20260407-gfx-clk-fixes-v1-4-4bb5583a5054@oss.qualcomm.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox