[PATCH v1 0/2] fixes to DRM doc & parameter's print

[PATCH v1 0/2] fixes to DRM doc & parameter's print

[Michał Grzelak]

Michał Grzelak (2):
  drm/print: describe 6th & 9th bit of drm.debug
  drm/managed: fix drmm_add_mod_or_reset() kernel-doc

 drivers/gpu/drm/drm_print.c | 4 +++-
 include/drm/drm_managed.h   | 2 +-
 include/drm/drm_print.h     | 2 +-
 3 files changed, 5 insertions(+), 3 deletions(-)

-- 
2.45.2

[PATCH v1 1/2] drm/print: describe 6th & 9th bit of drm.debug

[Michał Grzelak]

Setting 6th or 9th bit of drm.debug change debug logging. Meanwhile
`modinfo drm` does not inform about it at all.

Add info to MODULE_PARAM_DESC(debug, ...) about setting 6th and 9th bit
basing on DECLARE_DYNDBG_CLASSMAP(drm_debug_classes, ...). Match
description of corresponding bits with enum drm_debug_category. Include
9th bit in the example with enabling all possible logging provided at
comment at include/drm/drm_print.h.

Signed-off-by: Michał Grzelak <michal.grzelak@intel.com>
---
 drivers/gpu/drm/drm_print.c | 4 +++-
 include/drm/drm_print.h     | 2 +-
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/drm_print.c b/drivers/gpu/drm/drm_print.c
index ded9461df5f2..86cef1a37678 100644
--- a/drivers/gpu/drm/drm_print.c
+++ b/drivers/gpu/drm/drm_print.c
@@ -50,8 +50,10 @@ MODULE_PARM_DESC(debug, "Enable debug output, where each bit enables a debug cat
 "\t\tBit 3 (0x08)  will enable PRIME messages (prime code)\n"
 "\t\tBit 4 (0x10)  will enable ATOMIC messages (atomic code)\n"
 "\t\tBit 5 (0x20)  will enable VBL messages (vblank code)\n"
+"\t\tBit 6 (0x40)  will enable STATE messages (atomic state code)\n"
 "\t\tBit 7 (0x80)  will enable LEASE messages (leasing code)\n"
-"\t\tBit 8 (0x100) will enable DP messages (displayport code)");
+"\t\tBit 8 (0x100) will enable DP messages (displayport code)\n"
+"\t\tBit 9 (0x200) will enable DRMRES messages (managed resources code)");
 
 #if !defined(CONFIG_DRM_USE_DYNAMIC_DEBUG)
 module_param_named(debug, __drm_debug, ulong, 0600);
diff --git a/include/drm/drm_print.h b/include/drm/drm_print.h
index ab017b05e175..2adc5ac688e1 100644
--- a/include/drm/drm_print.h
+++ b/include/drm/drm_print.h
@@ -87,7 +87,7 @@ extern unsigned long __drm_debug;
  *  - drm.debug=0x2 will enable DRIVER messages
  *  - drm.debug=0x3 will enable CORE and DRIVER messages
  *  - ...
- *  - drm.debug=0x1ff will enable all messages
+ *  - drm.debug=0x3ff will enable all messages
  *
  * An interesting feature is that it's possible to enable verbose logging at
  * run-time by echoing the debug value in its sysfs node::
-- 
2.45.2

Re: [PATCH v1 1/2] drm/print: describe 6th & 9th bit of drm.debug

[Borah, Chaitanya Kumar]

On 5/21/2026 9:22 PM, Michał Grzelak wrote:
> Setting 6th or 9th bit of drm.debug change debug logging. Meanwhile
> `modinfo drm` does not inform about it at all.
> 
> Add info to MODULE_PARAM_DESC(debug, ...) about setting 6th and 9th bit
> basing on DECLARE_DYNDBG_CLASSMAP(drm_debug_classes, ...). Match
> description of corresponding bits with enum drm_debug_category. Include
> 9th bit in the example with enabling all possible logging provided at
> comment at include/drm/drm_print.h.
> 

LGTM

Reviewed-by: Chaitanya Kumar Borah <chaitanya.kumar.borah@intel.com>

> Signed-off-by: Michał Grzelak <michal.grzelak@intel.com>
> ---
>   drivers/gpu/drm/drm_print.c | 4 +++-
>   include/drm/drm_print.h     | 2 +-
>   2 files changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/drm_print.c b/drivers/gpu/drm/drm_print.c
> index ded9461df5f2..86cef1a37678 100644
> --- a/drivers/gpu/drm/drm_print.c
> +++ b/drivers/gpu/drm/drm_print.c
> @@ -50,8 +50,10 @@ MODULE_PARM_DESC(debug, "Enable debug output, where each bit enables a debug cat
>   "\t\tBit 3 (0x08)  will enable PRIME messages (prime code)\n"
>   "\t\tBit 4 (0x10)  will enable ATOMIC messages (atomic code)\n"
>   "\t\tBit 5 (0x20)  will enable VBL messages (vblank code)\n"
> +"\t\tBit 6 (0x40)  will enable STATE messages (atomic state code)\n"
>   "\t\tBit 7 (0x80)  will enable LEASE messages (leasing code)\n"
> -"\t\tBit 8 (0x100) will enable DP messages (displayport code)");
> +"\t\tBit 8 (0x100) will enable DP messages (displayport code)\n"
> +"\t\tBit 9 (0x200) will enable DRMRES messages (managed resources code)");
>   
>   #if !defined(CONFIG_DRM_USE_DYNAMIC_DEBUG)
>   module_param_named(debug, __drm_debug, ulong, 0600);
> diff --git a/include/drm/drm_print.h b/include/drm/drm_print.h
> index ab017b05e175..2adc5ac688e1 100644
> --- a/include/drm/drm_print.h
> +++ b/include/drm/drm_print.h
> @@ -87,7 +87,7 @@ extern unsigned long __drm_debug;
>    *  - drm.debug=0x2 will enable DRIVER messages
>    *  - drm.debug=0x3 will enable CORE and DRIVER messages
>    *  - ...
> - *  - drm.debug=0x1ff will enable all messages
> + *  - drm.debug=0x3ff will enable all messages
>    *
>    * An interesting feature is that it's possible to enable verbose logging at
>    * run-time by echoing the debug value in its sysfs node::

Claude review: drm/print: describe 6th & 9th bit of drm.debug

[Claude Code Review Bot]

Patch Review

**Correctness: Good.** The patch correctly adds the two missing bit descriptions to `MODULE_PARM_DESC`. Verified against the kernel tree:

The enum `drm_debug_category` in `include/drm/drm_print.h:98-142` defines entries in order: `DRM_UT_CORE`(0), `DRM_UT_DRIVER`(1), `DRM_UT_KMS`(2), `DRM_UT_PRIME`(3), `DRM_UT_ATOMIC`(4), `DRM_UT_VBL`(5), `DRM_UT_STATE`(6), `DRM_UT_LEASE`(7), `DRM_UT_DP`(8), `DRM_UT_DRMRES`(9). The `DECLARE_DYNDBG_CLASSMAP` at `drm_print.c:60` confirms the same order. The existing `MODULE_PARM_DESC` was indeed missing bit 6 (`STATE`) and bit 9 (`DRMRES`).

The added lines:
```
+"\t\tBit 6 (0x40)  will enable STATE messages (atomic state code)\n"
...
+"\t\tBit 9 (0x200) will enable DRMRES messages (managed resources code)");
```

These match the enum doc: `DRM_UT_STATE` is "verbose atomic state debugging" and `DRM_UT_DRMRES` is "drm managed resources code". The descriptions are consistent.

The change from `0x1ff` to `0x3ff` in `include/drm/drm_print.h:90` is also correct: with 10 categories (bits 0-9), all-bits-set is `0x3ff`, not `0x1ff` (which only covers bits 0-8). This was already wrong before `DRM_UT_DRMRES` was added — the comment was stale.

**No issues found.**

---
Generated by Claude Code Patch Reviewer

[PATCH v1 2/2] drm/managed: fix drmm_add_mod_or_reset() kernel-doc

[Michał Grzelak]

Kernel-doc of drmm_add_mode_or_reset() references @releases which is not
on argument list. Swap '@' between 'releases' and 'action' words to fix
the documentation.

Signed-off-by: Michał Grzelak <michal.grzelak@intel.com>
---
 include/drm/drm_managed.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/drm/drm_managed.h b/include/drm/drm_managed.h
index 72bfac002c06..72d0d68be226 100644
--- a/include/drm/drm_managed.h
+++ b/include/drm/drm_managed.h
@@ -18,7 +18,7 @@ typedef void (*drmres_release_t)(struct drm_device *dev, void *res);
  * @action: function which should be called when @dev is released
  * @data: opaque pointer, passed to @action
  *
- * This function adds the @release action with optional parameter @data to the
+ * This function adds the release @action with optional parameter @data to the
  * list of cleanup actions for @dev. The cleanup actions will be run in reverse
  * order in the final drm_dev_put() call for @dev.
  */
-- 
2.45.2

Re: [PATCH v1 2/2] drm/managed: fix drmm_add_mod_or_reset() kernel-doc

[Borah, Chaitanya Kumar]

On 5/21/2026 9:22 PM, Michał Grzelak wrote:
> Kernel-doc of drmm_add_mode_or_reset() references @releases which is not
> on argument list. Swap '@' between 'releases' and 'action' words to fix
> the documentation.

s/drmm_add_mode_or_reset/drmm_add_action

> 
> Signed-off-by: Michał Grzelak <michal.grzelak@intel.com>
> ---
>   include/drm/drm_managed.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/drm/drm_managed.h b/include/drm/drm_managed.h
> index 72bfac002c06..72d0d68be226 100644
> --- a/include/drm/drm_managed.h
> +++ b/include/drm/drm_managed.h
> @@ -18,7 +18,7 @@ typedef void (*drmres_release_t)(struct drm_device *dev, void *res);
>    * @action: function which should be called when @dev is released
>    * @data: opaque pointer, passed to @action
>    *
> - * This function adds the @release action with optional parameter @data to the
> + * This function adds the release @action with optional parameter @data to the
>    * list of cleanup actions for @dev. The cleanup actions will be run in reverse
>    * order in the final drm_dev_put() call for @dev.
>    */

Re: [PATCH v1 2/2] drm/managed: fix drmm_add_mod_or_reset() kernel-doc

[Michał Grzelak]

[-- Attachment #1: Type: text/plain, Size: 1309 bytes --]

On Fri, 22 May 2026, Borah, Chaitanya Kumar wrote:
> On 5/21/2026 9:22 PM, Michał Grzelak wrote:
>> Kernel-doc of drmm_add_mode_or_reset() references @releases which is not
>> on argument list. Swap '@' between 'releases' and 'action' words to fix
>> the documentation.
>
> s/drmm_add_mode_or_reset/drmm_add_action
>

Title would like to see that as well...

BR,
Michał

>> 
>> Signed-off-by: Michał Grzelak <michal.grzelak@intel.com>
>> ---
>>   include/drm/drm_managed.h | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/include/drm/drm_managed.h b/include/drm/drm_managed.h
>> index 72bfac002c06..72d0d68be226 100644
>> --- a/include/drm/drm_managed.h
>> +++ b/include/drm/drm_managed.h
>> @@ -18,7 +18,7 @@ typedef void (*drmres_release_t)(struct drm_device *dev, 
>> void *res);
>>    * @action: function which should be called when @dev is released
>>    * @data: opaque pointer, passed to @action
>>    *
>> - * This function adds the @release action with optional parameter @data to 
>> the
>> + * This function adds the release @action with optional parameter @data to 
>> the
>>    * list of cleanup actions for @dev. The cleanup actions will be run in 
>> reverse
>>    * order in the final drm_dev_put() call for @dev.
>>    */
>
>

Claude review: drm/managed: fix drmm_add_mod_or_reset() kernel-doc

[Claude Code Review Bot]

Patch Review

**Correctness: Good.** The existing kernel-doc at `include/drm/drm_managed.h:21` says:

```
 * This function adds the @release action with optional parameter @data to the
```

The parameter is named `action`, not `release` — there is no `@release` parameter in the argument list (lines 17-18 list `@dev`, `@action`, `@data`). The fix correctly changes this to:

```
 * This function adds the release @action with optional parameter @data to the
```

This is the right fix — `@action` now correctly references the documented parameter.

**Minor nit:** The commit subject says "drmm_add_mod_or_reset()" but the actual macro is `drmm_add_action` (line 25 of `drm_managed.h`). The kernel-doc comment block at line 16 is for `drmm_add_action`, not `drmm_add_action_or_reset` (which has its own doc block starting at line 32). The subject line appears to have a typo — it should say `drmm_add_action()`. The same doc issue also exists in the `drmm_add_action_or_reset` block at line 38-39 (`@release` should be `@action` there too), but that's not addressed in this patch.

**Summary:** Both patches are correct and should be applied. The only suggestion is fixing the commit subject typo in patch 2, and optionally fixing the same `@release` → `@action` issue in the `drmm_add_action_or_reset` doc block while at it.

---
Generated by Claude Code Patch Reviewer

Claude review: fixes to DRM doc & parameter's print

[Claude Code Review Bot]

Overall Series Review

Subject: fixes to DRM doc & parameter's print
Author: =?UTF-8?q?Micha=C5=82=20Grzelak?= <michal.grzelak@intel.com>
Patches: 6
Reviewed: 2026-05-25T19:48:10.684025

---

This is a small, straightforward documentation-fix series (2 patches). Patch 1 fills in missing entries in the `MODULE_PARM_DESC` for `drm.debug` (bits 6 and 9) and corrects the "enable all" example value. Patch 2 fixes a kernel-doc `@parameter` reference typo. Both patches are correct and low-risk. One minor nit on patch 2 worth noting.

---
Generated by Claude Code Patch Reviewer

[PATCH v2 0/2] fixes to DRM doc & parameter's print

[Michał Grzelak]

Next version of [1]. Changed commit message to mention kernel-doc of
actually changed macro.

[1] https://lore.kernel.org/intel-gfx/20260521155231.1821935-1-michal.grzelak@intel.com/

BR,
Michał

Michał Grzelak (2):
  drm/print: describe 6th & 9th bit of drm.debug
  drm/managed: fix drmm_add_action() kernel-doc

 drivers/gpu/drm/drm_print.c | 4 +++-
 include/drm/drm_managed.h   | 2 +-
 include/drm/drm_print.h     | 2 +-
 3 files changed, 5 insertions(+), 3 deletions(-)

-- 
2.45.2

Claude review: fixes to DRM doc & parameter's print

[Claude Code Review Bot]

Overall Series Review

Subject: fixes to DRM doc & parameter's print
Author: =?UTF-8?q?Micha=C5=82=20Grzelak?= <michal.grzelak@intel.com>
Patches: 4
Reviewed: 2026-05-25T18:29:26.862760

---

This is a clean, straightforward 2-patch series that fixes documentation gaps in the DRM debug subsystem. Both patches are correct and address real issues: missing bit descriptions in `MODULE_PARM_DESC`, an out-of-date "enable all" bitmask comment, and a kernel-doc `@parameter` reference error. No functional code changes. The series is small, well-scoped, and ready to merge.

**Verdict: Looks good.**

---
Generated by Claude Code Patch Reviewer